Makefile: simpily ledger build tags (backport #2449) #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
In the process of working on the `goreleaser` PR I discovered that how we are building the `BUILD_TAGS` is overly verbose and unnecessary. Ultimately we are just trying to add `ledger` to `-tags`. Hardcoding it and adding a note in the README for the 2 distributions that aren't supported seemed easier to maintain. (cherry picked from commit 67241f9) # Conflicts: # specs/src/SUMMARY.md
mergify
bot
requested review from
liamsi,
adlerjohn and
evan-forbes
as code owners
|
Codecov Report
@@ Coverage Diff @@
## v1.x #2612 +/- ##
=======================================
Coverage 20.41% 20.41%
=======================================
Files 140 140
Lines 15934 15934
=======================================
Hits 3253 3253
Misses 12373 12373
Partials 308 308 |
rootulp
approved these changes
Oct 4, 2023
rach-id
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2449 done by Mergify.
Closes #2597