-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updates docker file by exposing the tracing port 26661 #3334
Conversation
Do we want to have tracing enabled in v1.x? if not, then I'll remove the backporting tag. |
WalkthroughWalkthroughThe update in the Changes
Possibly related issues
Recent Review DetailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Seems fine to me if the tracing features already exist on v1.x |
The port `:26661` needs to be exposed in order to access traced data. Please see https://github.com/celestiaorg/celestia-core/tree/main/pkg/trace#pull-based-event-collection. Part of #3318 (cherry picked from commit b2566e2) # Conflicts: # Dockerfile
…aorg#3334) The port `:26661` needs to be exposed in order to access traced data. Please see https://github.com/celestiaorg/celestia-core/tree/main/pkg/trace#pull-based-event-collection. Part of celestiaorg#3318
…#3334) (#3335) The port `:26661` needs to be exposed in order to access traced data. Please see https://github.com/celestiaorg/celestia-core/tree/main/pkg/trace#pull-based-event-collection. Part of #3318<hr>This is an automatic backport of pull request #3334 done by [Mergify](https://mergify.com). --------- Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com> Co-authored-by: sanaz <sanaztaheri@ieee.org> Co-authored-by: Rootul P <rootulp@gmail.com>
The port
:26661
needs to be exposed in order to access traced data. Please see https://github.com/celestiaorg/celestia-core/tree/main/pkg/trace#pull-based-event-collection.Part of #3318