Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orchestrator old signatures replay #351

Merged
merged 40 commits into from
Apr 29, 2022

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Apr 25, 2022

Add valsets/Data commitment orchestrator signature replay.
Closes: #337 #336

@rach-id rach-id added the C: QGB label Apr 25, 2022
@rach-id rach-id self-assigned this Apr 25, 2022
@rach-id rach-id marked this pull request as draft April 25, 2022 12:49
@rach-id rach-id marked this pull request as ready for review April 28, 2022 10:00
@rach-id rach-id changed the title WIP: Orchestrator replay Orchestrator old signatures replay Apr 28, 2022
@rach-id
Copy link
Member Author

rach-id commented Apr 28, 2022

This one is ready for review also

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having to resort to things like this is not ideal, and rather messy imho, but I understand why and we should be able to clean up most of this using the worker pool model later

x/qgb/orchestrator/orchestrator_client.go Show resolved Hide resolved
x/qgb/orchestrator/orchestrator_client.go Outdated Show resolved Hide resolved
x/qgb/orchestrator/orchestrator_client.go Outdated Show resolved Hide resolved
x/qgb/orchestrator/orchestrator_client.go Outdated Show resolved Hide resolved
x/qgb/orchestrator/orchestrator_client.go Show resolved Hide resolved
x/qgb/orchestrator/orchestrator_client.go Outdated Show resolved Hide resolved
x/qgb/orchestrator/orchestrator_client.go Outdated Show resolved Hide resolved
x/qgb/orchestrator/querier.go Outdated Show resolved Hide resolved
x/qgb/orchestrator/relayer.go Outdated Show resolved Hide resolved
Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

❗ No coverage uploaded for pull request base (qgb-integration@4fe09dc). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             qgb-integration     #351   +/-   ##
==================================================
  Coverage                   ?   11.82%           
==================================================
  Files                      ?       55           
  Lines                      ?    11071           
  Branches                   ?        0           
==================================================
  Hits                       ?     1309           
  Misses                     ?     9672           
  Partials                   ?       90           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fe09dc...11abe2c. Read the comment docs.

Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but will defer to @evan-forbes

Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had one minor nit left, but pre aproving

lgtm 👍

@rach-id rach-id merged commit 45109e5 into celestiaorg:qgb-integration Apr 29, 2022
@rach-id rach-id deleted the orchestrator_replay branch April 29, 2022 15:12
rach-id added a commit to rach-id/celestia-app that referenced this pull request May 9, 2022
* adds valset request by nonce

* add querier, broadcaster and updates orchestrator to use them

* partially fix the tests for the new design

* update the deployer for the new design

* update orchestrator to new design

* Adds querier and evm client update

* update relayer to new design

* fix query.proto

* update deploy_command to use new Querier

* formatting

* formatting

* go.sum

* adds query last unbonding height

* adds orchestrator valset replay

* adds orchestrator data commitment replay

* cosmetics

* puts valset signature catchup in a separate function

* puts data commitment signature catchup in a separate function

* Querier cosmetics

* go.sum

* rename querier and catchup functions

* adds genesis case to querylastvalset

* format + todo

* initialized tm logger in test

* update orchestrator code to use uint64 instead of int64

* better logging

* Update x/qgb/orchestrator/orchestrator_client.go

Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>

* formats import

* rename addOldValsetAttestations and addOldDataCommitmentAttestations

* defering logging instead of repeating it on every return

* adds comment

* Update x/qgb/orchestrator/relayer.go

Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>

* Update x/qgb/orchestrator/querier.go

Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>

* remove unnecessary error

Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

QGB replaying data commitments orchestrator signatures QGB replaying Valsets orchestrator signatures
4 participants