Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds integration tests scenarios to QGB #423

Merged
merged 52 commits into from
May 26, 2022
Merged

Adds integration tests scenarios to QGB #423

merged 52 commits into from
May 26, 2022

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented May 19, 2022 •
edited
Loading

Closing #407 #324

@rach-id
adds docker-compose config to start 4 celestia-app validators
a1182a3
@rach-id
dummy tests
f5ee48b
@rach-id
Merge branch 'qgb-integration' into qgb_integration_test
487372c 
# Conflicts:
#	go.mod
#	go.sum
@rach-id
Merge branch 'qgb-integration' into qgb_integration_test
0ea815b
@rach-id
adds infrastructure for 4 validators and scripts to start them
de598a8
@rach-id
remove unnecessary file
4b94b36
@rach-id
working 4 validators network + use a single script to start the valid…
425eafb 
…ators
@rach-id
adds initial orchestrator/relayer docker-compose configuration
b272372
@rach-id
Merge branch 'qgb-integration' into qgb_integration_test_environment
58170d0
@rach-id
fixes docker-compose commands + improves deployment script
dff5059
@rach-id
adds todo
677ad70
@rach-id
adds qgb_network and service
5f4a366
@rach-id
adds more methods to QGBContract
ba90d01
@rach-id
adds first relayer_test
e294456
@rach-id
comments unnecessary test
a6c2479
@rach-id
Merge branch 'qgb-integration' into qgb_integration_test_environment
bf9689f
@rach-id
install curl when running validators scripts
bdb1d9b
@rach-id
query block 1 before deploying QGB contract
1fefa17
@rach-id
use updated dockerfile for repo
2b5e60d
@rach-id
improve qgb_network and move it to separate folder
8d55117
@rach-id
adds relayer e2e tests
cf34872
@rach-id
Merge branch 'qgb-integration' into qgb_integration_test_environment
eaec672
@rach-id
remove unnecessary qgb_address.txt
90e1808
@rach-id
decrease block time
a4c5583
@rach-id
reorg and add new helper methods
4a1ef8c
@rach-id
simpler environment variables to deploy qgb contract
a183655
@rach-id
adds FIXME
f2eff2c
@rach-id
unnecessary linter comment
8e0ed40
@rach-id
better testing scenarios
d74f406
@rach-id
add full test
94290f1
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (qgb-integration@d5d3834). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             qgb-integration     #423   +/-   ##
==================================================
  Coverage                   ?   11.47%           
==================================================
  Files                      ?       60           
  Lines                      ?    11487           
  Branches                   ?        0           
==================================================
  Hits                       ?     1318           
  Misses                     ?    10082           
  Partials                   ?       87

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d3834...83c30e6. Read the comment docs.

@rach-id rach-id mentioned this pull request May 20, 2022
Merged
@rach-id
Merge branch 'qgb-integration' into adds_integration_tests_scenarios
1172870 
# Conflicts:
#	.github/workflows/docker-build.yml
#	e2e/qgb/celestia-app/start_orchestrator_after_validator_created.sh
@rach-id
revert unneeded change
b63f42f
@rach-id rach-id requested a review from evan-forbes May 23, 2022 12:15
@rach-id rach-id marked this pull request as ready for review May 23, 2022 12:15
@rach-id rach-id mentioned this pull request May 24, 2022
Merged
@evan-forbes
Copy link
Member

wow wow wow, this test makes my laptop fan whrrrrrrrrrrrr, this is super cool!! So I got the network up just by calling docker compose, but when I run the tests they say they aren't connected to the docker daemon?

Perhaps we could add a quick read me on how to run?

@rach-id
Copy link
Member Author

rach-id commented May 26, 2022

You run nothing by yourself. The network is started automatically.
You just run QGB_INTEGRATION_TEST=true go test from the e2e/qgb folder and it will run.
I added a makefile in a another PR that depends on this.

@rach-id
Copy link
Member Author

rach-id commented May 26, 2022

README PR #449 but requires few PRs to be merged before it can be merged

@rach-id
Copy link
Member Author

rach-id commented May 26, 2022

To run the tests in this branch:

$ QGB_INTEGRATION_TEST=true go test -mod=readonly -test.timeout 30m -failfast -v

And, to clean the environemnt in case of errors: https://github.com/celestiaorg/celestia-app/blob/da9eda070a6c9d8193c2043b507bde7d9d82cab3/e2e/qgb/scripts/cleanup.sh

evan-forbes
evan-forbes approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rachid and I went through these tests and we were able to run them using comments above

nice work!!

@rach-id rach-id merged commit 7ea764c into celestiaorg:qgb-integration May 26, 2022
@rach-id rach-id deleted the adds_integration_tests_scenarios branch May 26, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

Assignees

@rach-id rach-id

Labels
testing items that are strictly related to adding or extending test coverage
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rach-id @codecov-commenter @evan-forbes