Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qgb integration test environment #408

Merged
merged 41 commits into from
May 23, 2022
Merged

Qgb integration test environment #408

merged 41 commits into from
May 23, 2022

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented May 13, 2022 •
edited
Loading

Closing #398 #325

@rach-id rach-id marked this pull request as draft May 13, 2022 23:51
@rach-id rach-id self-assigned this May 13, 2022
@rach-id rach-id added the C: QGB label May 13, 2022
@adlerjohn adlerjohn linked an issue May 14, 2022 that may be closed by this pull request
QGB E2E test proposal #398
Closed
@rach-id rach-id mentioned this pull request May 19, 2022
Merged
@rach-id
Copy link
Member Author

rach-id commented May 19, 2022

depends on #415

@rach-id rach-id marked this pull request as ready for review May 20, 2022 13:42
@rach-id rach-id requested a review from evan-forbes May 20, 2022 13:42
@rach-id
Copy link
Member Author

rach-id commented May 20, 2022

This is ready for review

evan-forbes
evan-forbes reviewed May 20, 2022
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, this is so cleeaann, will try test later today

e2e/qgb/celestia-app/deploy_qgb_contract.sh Show resolved Hide resolved
x/qgb/keeper/query_data_commitment.go Show resolved Hide resolved
@evan-forbes evan-forbes added the testing items that are strictly related to adding or extending test coverage label May 20, 2022
@rach-id
Copy link
Member Author

rach-id commented May 20, 2022

@evan-forbes If you wanna test it locally, try this one #423 as this PR only contains the environment, not the actual test scenarios

@adlerjohn adlerjohn linked an issue May 20, 2022 that may be closed by this pull request
Implement a dockerized deployment of a celestia testnet bridged to an ethereuem testnet by the qgb #325
Closed
@rach-id
Copy link
Member Author

rach-id commented May 21, 2022

Will replace the:

        if os.Getenv("QGB_INTEGRATION_TEST") != TRUE {
		t.Skip("Skipping QGB integration tests")
	}

	network, err := NewQGBNetwork()
	HandleNetworkError(t, network, err, false)

	// preferably, run this also when ctrl+c
	defer network.DeleteAll() //nolint:errcheck

with an IntegrationTestSuite as of #428 in a subsequent PR

@rach-id rach-id mentioned this pull request May 23, 2022
Closed
evan-forbes
evan-forbes approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is about as minimal as a setup as I could imagine for a dockerized e2e test. Well done!

utACK

e2e/qgb/qgb_network.go Show resolved Hide resolved
@rach-id rach-id mentioned this pull request May 23, 2022
Closed
@rach-id rach-id merged commit d5d3834 into celestiaorg:qgb-integration May 23, 2022
@rach-id rach-id deleted the qgb_integration_test_environment branch May 23, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

Assignees

@rach-id rach-id

Labels
testing items that are strictly related to adding or extending test coverage
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
2 participants
@rach-id @evan-forbes