Qgb e2e GitHub action #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
depends on #443 |
rach-id
force-pushed
the
qgb_e2e_github_action
branch
from
24ba762
to
61271a0
Compare
evan-forbes
approved these changes
May 26, 2022
| go.mod | ||
| go.sum | ||
| - name: Test | ||
| run: go test -test.timeout 30m -failfast -v github.com/celestiaorg/celestia-app/e2e/qgb |
There was a problem hiding this comment.
super minor nit: perhaps we could use make test here so that if we make any changes to that in the future it will also be reflected here? We might specifically want differences though, so if that's the case pls ignore 🙂
There was a problem hiding this comment.
I want to have the -failfast flag here so that if one test fails, the job doesn't keep running for more time and the dev can go run things locally and see what's the problem.
If not, we will need to wait for around 20 min for all the tests to execute, which is too much.
What do you think?
|
we can merge w/o all tests passing imho as we are expecting the full test to fail atm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds simple github action to run QGB E2E.
Closing #409