Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGB update relayer to work in multiple validators environment #445

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented May 24, 2022

This fixes the relay mechanism for valsets in multiple validators' environment.
However, it does not address data commitments as the following issue is still not addressed #370

@rach-id rach-id added the C: QGB label May 24, 2022
@rach-id rach-id self-assigned this May 24, 2022
@rach-id rach-id marked this pull request as draft May 24, 2022 22:43
@rach-id
Copy link
Member Author

rach-id commented May 24, 2022

depends on: #444

x/qgb/orchestrator/querier.go Outdated Show resolved Hide resolved
x/qgb/orchestrator/querier.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (qgb-integration@d5d3834). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             qgb-integration     #445   +/-   ##
==================================================
  Coverage                   ?   11.44%           
==================================================
  Files                      ?       60           
  Lines                      ?    11518           
  Branches                   ?        0           
==================================================
  Hits                       ?     1318           
  Misses                     ?    10113           
  Partials                   ?       87           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d3834...5b36440. Read the comment docs.

@rach-id rach-id force-pushed the fix_relayer_multiple_signatures_relaying branch from 5b36440 to c426a16 Compare May 26, 2022 16:38
@rach-id rach-id requested a review from evan-forbes May 26, 2022 16:38
@rach-id rach-id marked this pull request as ready for review May 26, 2022 16:38
@rach-id rach-id merged commit bfa7827 into celestiaorg:qgb-integration May 26, 2022
@rach-id rach-id deleted the fix_relayer_multiple_signatures_relaying branch May 26, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants