Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGB remove unnecessary keystore #527

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Jul 7, 2022

Removes the custom key_store implementation and uses existing one. Also, updates tests.
Closes #498

@rach-id rach-id added the C: QGB label Jul 7, 2022
@rach-id rach-id self-assigned this Jul 7, 2022
@rach-id rach-id marked this pull request as draft July 7, 2022 01:29
@rach-id
Copy link
Member Author

rach-id commented Jul 7, 2022

Depends on #526

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #527 (0b53330) into qgb-integration (458b6b2) will decrease coverage by 2.06%.
The diff coverage is 20.12%.

@@                Coverage Diff                 @@
##           qgb-integration    #527      +/-   ##
==================================================
- Coverage            11.72%   9.66%   -2.07%     
==================================================
  Files                   65      55      -10     
  Lines                10881    9394    -1487     
==================================================
- Hits                  1276     908     -368     
+ Misses                9515    8404    -1111     
+ Partials                90      82       -8     
Impacted Files Coverage Δ
e2e/qgb/qgb_network.go 0.00% <0.00%> (ø)
e2e/qgb/test_commons.go 0.00% <ø> (ø)
x/qgb/keeper/hooks.go 34.61% <ø> (+2.47%) ⬆️
x/qgb/keeper/keeper_attestation.go 24.52% <0.00%> (ø)
x/qgb/keeper/keeper_data_commitment_confirm.go 42.85% <ø> (ø)
x/qgb/keeper/keeper_valset.go 32.00% <0.00%> (-7.51%) ⬇️
x/qgb/keeper/msg_server.go 0.00% <0.00%> (ø)
x/qgb/keeper/query_attestation.go 0.00% <ø> (ø)
x/qgb/keeper/query_general.go 0.00% <0.00%> (ø)
x/qgb/keeper/query_valset.go 0.00% <ø> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 458b6b2...0b53330. Read the comment docs.

@rach-id rach-id marked this pull request as ready for review July 13, 2022 12:33
@rach-id rach-id requested a review from evan-forbes July 13, 2022 12:33
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lit

@rach-id rach-id merged commit e399df5 into celestiaorg:qgb-integration Jul 13, 2022
@rach-id rach-id deleted the key_store branch July 13, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants