-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QGB CLI takes time to execute #526
Conversation
depends on #524 |
Codecov Report
@@ Coverage Diff @@
## qgb-integration #526 +/- ##
==================================================
- Coverage 12.51% 9.68% -2.83%
==================================================
Files 56 55 -1
Lines 9679 9368 -311
==================================================
- Hits 1211 907 -304
+ Misses 8385 8379 -6
+ Partials 83 82 -1
Continue to review full report at Codecov.
|
great find!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The CLI commands were taking time to execute because a testing helper file was initializing a lot of resources for the tests, and the file wasn't suffixed with
_test
. Thus, it was initializing those resources on every command run.Closes #451