Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename to ContinuationCompactShareContentSize #803

Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Sep 27, 2022

Part of #725

Rename CompactShareContentSize to ContinuationCompactShareContentSize because we will soon introduce a new appconst for FirstCompactShareContentSize.

Part of celestiaorg#725

Motivation: we will soon introduce a new appconst for
`FirstCompactShareContentSize`
@rootulp rootulp self-assigned this Sep 27, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #803 (2c4cd72) into main (ab55fc4) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #803   +/-   ##
=======================================
  Coverage   23.28%   23.28%           
=======================================
  Files          71       71           
  Lines        8788     8788           
=======================================
  Hits         2046     2046           
  Misses       6570     6570           
  Partials      172      172           
Impacted Files Coverage Δ
app/estimate_square_size.go 82.66% <100.00%> (ø)
pkg/prove/proof.go 82.08% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rootulp rootulp marked this pull request as ready for review September 27, 2022 20:16
@rootulp rootulp enabled auto-merge (squash) September 27, 2022 20:16
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I see where this is going, so :shipit:

@rootulp rootulp merged commit 595fd3b into celestiaorg:main Sep 27, 2022
rootulp added a commit that referenced this pull request Sep 28, 2022
rach-id pushed a commit to rach-id/celestia-app that referenced this pull request Nov 16, 2022
Part of celestiaorg#725

Rename `CompactShareContentSize` to
`ContinuationCompactShareContentSize` because we will soon introduce a
new appconst for `FirstCompactShareContentSize`.
rach-id pushed a commit to rach-id/celestia-app that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants