feat: introduce FirstCompactShareContentSize
#804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of celestiaorg#725 Motivation: we will soon introduce a new appconst for `FirstCompactShareContentSize`
evan-forbes
reviewed
Sep 27, 2022
Codecov Report
@@ Coverage Diff @@
## main #804 +/- ##
=======================================
Coverage 23.31% 23.31%
=======================================
Files 71 71
Lines 8792 8792
=======================================
Hits 2050 2050
Misses 6570 6570
Partials 172 172 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
evan-forbes
previously approved these changes
Sep 28, 2022
This reverts commit 285d1a2.
evan-forbes
approved these changes
Sep 28, 2022
evan-forbes
added a commit
that referenced
this pull request
Sep 28, 2022
as noticed in #804 (comment), I forgot to delete the old `DelimLen` function after fixing a bug in #747.
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
~~Blocked on celestiaorg#803 Part of celestiaorg#725
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
as noticed in celestiaorg#804 (comment), I forgot to delete the old `DelimLen` function after fixing a bug in celestiaorg#747.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on #803Part of #725