Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ParseShares failed to append last sequence #872

Merged
merged 1 commit into from
Oct 14, 2022
Merged

fix: ParseShares failed to append last sequence #872

merged 1 commit into from
Oct 14, 2022

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Oct 14, 2022

After correcting an error in unit tests:

-			if reflect.DeepEqual(got, tt.want) {
+			if !reflect.DeepEqual(got, tt.want) {

unit tests surfaced an error with the current ParseShares implementation. The last currentSequence wasn't appended to the result prior to returning.

@rootulp rootulp self-assigned this Oct 14, 2022
@rootulp rootulp mentioned this pull request Oct 14, 2022
Merged
@rootulp rootulp merged commit 35e465e into celestiaorg:main Oct 14, 2022
@rootulp rootulp deleted the rp/fix-parse-shares branch October 14, 2022 13:07
rach-id pushed a commit to rach-id/celestia-app that referenced this pull request Nov 16, 2022
@rootulp @rach-id
fix: ParseShares failed to append last sequence (celestiaorg#872)
73d8aaf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rach-id rach-id rach-id approved these changes

@evan-forbes evan-forbes Awaiting requested review from evan-forbes

Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rootulp @rach-id