shrex nd should blacklist peers that send invalid data

celestiaorg · May 19, 2023 · 2db5afe · 2db5afe
1 parent bd70494
commit 2db5afe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/share/getters/shrex.go b/share/getters/shrex.go
@@ -211,6 +211,10 @@ func (sg *ShrexGetter) GetSharesByNamespace(
 		cancel()
 		switch {
 		case getErr == nil:
+			if getErr = nd.Verify(root, id); getErr != nil {
+				setStatus(peers.ResultBlacklistPeer)
+				break
+			}
 			setStatus(peers.ResultNoop)
 			sg.metrics.recordNDAttempt(ctx, attempt, true)
 			return nd, nil

diff --git a/share/p2p/shrexnd/client.go b/share/p2p/shrexnd/client.go
@@ -127,12 +127,6 @@ func (c *Client) doRequest(
 	if err != nil {
 		return nil, fmt.Errorf("client-nd: converting response to shares: %w", err)
 	}
-
-	err = shares.Verify(root, nID)
-	if err != nil {
-		return nil, fmt.Errorf("client-nd: verifying response: %w", err)
-	}
-
 	return shares, nil
 }