Skip to content

Commit

Permalink
ci: run unit tests on m1 mac runner vs macos-latest intel mac (#3155)
Browse files Browse the repository at this point in the history
<!--
Thank you for submitting a pull request!

Please make sure you have reviewed our contributors guide before
submitting your
first PR.

Please ensure you've addressed or included references to any related
issues.

Tips:
- Use keywords like "closes" or "fixes" followed by an issue number to
automatically close related issues when the PR is merged (e.g., "closes
#123" or "fixes #123").
- Describe the changes made in the PR.
- Ensure the PR has one of the required tags (kind:fix, kind:misc,
kind:break!, kind:refactor, kind:feat, kind:deps, kind:docs, kind:ci,
kind:chore, kind:testing)

-->

These are now [generally
available](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/)
and these will a) be faster b) also be closer to developer machines

also removed a commented out job in the ci_release.yml file that had
been sitting dormant for a few years
  • Loading branch information
ramin committed Feb 9, 2024
1 parent 257e6ce commit 3b97e71
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
8 changes: 0 additions & 8 deletions .github/workflows/ci_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,3 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GPG_FINGERPRINT: ${{ steps.import_gpg.outputs.fingerprint }}

# TODO: permission issue, but not worth fixing as this should be refactored
# into the celestiaorg/.github repo, at which point any permission issues will
# be resolved.
#
# docker:
# needs: [release]
# uses: ./.github/workflows/docker-build.yml
2 changes: 1 addition & 1 deletion .github/workflows/go-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest]
os: [ubuntu-latest, macos-14]
runs-on: ${{ matrix.os }}
env:
OS: ${{ matrix.os }}
Expand Down

0 comments on commit 3b97e71

Please sign in to comment.