Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

share/discovery: DiscardPeer method #2204

Closed
Wondertan opened this issue May 15, 2023 · 0 comments · Fixed by #2207
Closed

share/discovery: DiscardPeer method #2204

Wondertan opened this issue May 15, 2023 · 0 comments · Fixed by #2207
Assignees
@Wondertan
Labels
needs:triage

Comments

@Wondertan
Copy link
Member

We need a way for the peer manager to report back to discovery if some peer is not useful anymore and to discover someone else instead.
@Wondertan Wondertan self-assigned this May 15, 2023
@Wondertan Wondertan mentioned this issue May 15, 2023
Merged
Wondertan added a commit that referenced this issue May 16, 2023
@Wondertan
feat(share/discovery): Discard method (#2207)
ac0f0e3 
Fixes #2204

Regarding the case where we exhausted all the peers on the network and backed them all off. It can happen on the smaller network, and in the worst case, the node will wait 10 minutes(the default backoff time), which is acceptable considering peers from shrexsub #2105
vgonkivs pushed a commit to vgonkivs/celestia-node that referenced this issue May 22, 2023
@Wondertan @vgonkivs
feat(share/discovery): Discard method (celestiaorg#2207)
e6fc246 
Fixes celestiaorg#2204

Regarding the case where we exhausted all the peers on the network and backed them all off. It can happen on the smaller network, and in the worst case, the node will wait 10 minutes(the default backoff time), which is acceptable considering peers from shrexsub celestiaorg#2105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wondertan Wondertan

Labels
needs:triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(share/discovery): Discard method celestiaorg/celestia-node
1 participant
@Wondertan