nodebuilder/state: Make SubmitTx endpoint a read-level permission
#2958
Labels
Comments
renaynay
added
good first issue
renaynay
pushed a commit
that referenced
this issue
Jan 19, 2024
…ons (#3072) <!-- Thank you for submitting a pull request! Please make sure you have reviewed our contributors guide before submitting your first PR. Please ensure you've addressed or included references to any related issues. Tips: - Use keywords like "closes" or "fixes" followed by an issue number to automatically close related issues when the PR is merged (e.g., "closes #123" or "fixes #123"). - Describe the changes made in the PR. - Ensure the PR has one of the required tags (kind:fix, kind:misc, kind:break!, kind:refactor, kind:feat, kind:deps, kind:docs, kind:ci, kind:chore, kind:testing) --> refactor: changes SubmitTX permissions from write to read. Following the issue requirement, this PR changes SubmitTX permissions from _write_ to _read_ Changes: * Updated nodebuilder/state/state.go from **write** to **read** permissions * Updated following tests (api/rpc_test.go) and added extra check for SubmitTX rpc call (read permissions check). closes #2958 --------- Co-authored-by: [NODERS]TEAM <office@noders.team> Co-authored-by: ramin <raminkeene@gmail.com>
renaynay
pushed a commit
that referenced
this issue
Jan 23, 2024
…ons (#3072) <!-- Thank you for submitting a pull request! Please make sure you have reviewed our contributors guide before submitting your first PR. Please ensure you've addressed or included references to any related issues. Tips: - Use keywords like "closes" or "fixes" followed by an issue number to automatically close related issues when the PR is merged (e.g., "closes #123" or "fixes #123"). - Describe the changes made in the PR. - Ensure the PR has one of the required tags (kind:fix, kind:misc, kind:break!, kind:refactor, kind:feat, kind:deps, kind:docs, kind:ci, kind:chore, kind:testing) --> refactor: changes SubmitTX permissions from write to read. Following the issue requirement, this PR changes SubmitTX permissions from _write_ to _read_ Changes: * Updated nodebuilder/state/state.go from **write** to **read** permissions * Updated following tests (api/rpc_test.go) and added extra check for SubmitTX rpc call (read permissions check). closes #2958 --------- Co-authored-by: [NODERS]TEAM <office@noders.team> Co-authored-by: ramin <raminkeene@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's not necessary to have
SubmitTxbehindwrite-level permissions as the transaction that would be submitted through that endpoint would already have to be signed. Thus, we can have it asreadlevel only.The text was updated successfully, but these errors were encountered: