refactor(service/state): CoreAccessor relies on header.Head instead of header.Getter
#1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
added
kind:improvement
area:header
Codecov Report
@@ Coverage Diff @@
## main #1088 +/- ##
==========================================
+ Coverage 56.82% 56.84% +0.01%
==========================================
Files 136 136
Lines 9063 9064 +1
==========================================
+ Hits 5150 5152 +2
Misses 3372 3372
+ Partials 541 540 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
renaynay
requested review from
liamsi,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
distractedm1nd
previously approved these changes
Sep 14, 2022
walldiss
previously approved these changes
Sep 14, 2022
Wondertan
previously approved these changes
Sep 14, 2022
…ce and lint core_access.go imports
renaynay
dismissed stale reviews from Wondertan, walldiss, and distractedm1nd
via
4482f43
renaynay
force-pushed
the
state-rely-on-sync-head
branch
from
03686b7
to
4482f43
Compare
Wondertan
approved these changes
Sep 19, 2022
distractedm1nd
approved these changes
Sep 19, 2022
distractedm1nd
pushed a commit
to distractedm1nd/celestia-node
that referenced
this pull request
Sep 21, 2022
…ad of `header.Getter` (celestiaorg#1088) * refactor(service/state): Remove unused header.Getter from state service and lint core_access.go imports * refactor(header): Extract Head method from Getter into its own interface `Head` * feat(header/sync): Syncer implements header.Head * doc(header/sync): document Head method better * refactor(service/state): CoreAccessor takes header.Head instead of header.Getter
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoreAccessorrelies on theSyncerimplementation ofheader.Headinstead of theheader.Storeimplementation ofheader.Getterin order to provide access to more current network head, and consequently, balance information.