-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blocksync): share.ReadEDS
#1158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distractedm1nd
added
area:shares
Shares and samples
kind:feat
Attached to feature PRs
labels
Sep 23, 2022
Codecov Report
@@ Coverage Diff @@
## main #1158 +/- ##
==========================================
- Coverage 57.10% 56.98% -0.13%
==========================================
Files 139 140 +1
Lines 9357 9519 +162
==========================================
+ Hits 5343 5424 +81
- Misses 3467 3528 +61
- Partials 547 567 +20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
vgonkivs
reviewed
Sep 30, 2022
vgonkivs
reviewed
Sep 30, 2022
vgonkivs
reviewed
Sep 30, 2022
distractedm1nd
force-pushed
the
readeds
branch
from
October 4, 2022 15:08
5cccc73
to
48bfd98
Compare
distractedm1nd
force-pushed
the
readeds
branch
2 times, most recently
from
October 14, 2022 04:58
490e27c
to
fb59097
Compare
distractedm1nd
force-pushed
the
readeds
branch
2 times, most recently
from
October 18, 2022 08:12
f5e8b4f
to
a7cfcd1
Compare
renaynay
reviewed
Oct 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny nits.
Wondertan
previously approved these changes
Oct 19, 2022
TODO:
From: @renaynay
|
distractedm1nd
force-pushed
the
readeds
branch
from
October 20, 2022 07:20
8c87c83
to
be1459d
Compare
distractedm1nd
requested review from
Wondertan,
renaynay,
vgonkivs and
walldiss
October 20, 2022 07:22
Wondertan
approved these changes
Oct 20, 2022
renaynay
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1104
Includes implementation and tests
Based on #1139
The base of this PR will change along with 1139 when the feature branch is set up and ready