Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(gateway): reenabling gateway, adding flag to enable #1199

Merged
merged 4 commits into from
Oct 28, 2022

Conversation

distractedm1nd
Copy link
Member

@distractedm1nd distractedm1nd commented Oct 5, 2022

It adds the gateway back onto the node (closes #1182) with it's own config, disabled by default, which is activated by the flag --gateway (closes #1183).

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #1199 (f70ca3b) into main (cb92051) will increase coverage by 0.29%.
The diff coverage is 54.42%.

❗ Current head f70ca3b differs from pull request most recent head cb941ac. Consider uploading reports for the commit cb941ac to get more accurate results

@@            Coverage Diff             @@
##             main    #1199      +/-   ##
==========================================
+ Coverage   55.56%   55.85%   +0.29%     
==========================================
  Files         162      168       +6     
  Lines        9981    10167     +186     
==========================================
+ Hits         5546     5679     +133     
- Misses       3881     3924      +43     
- Partials      554      564      +10     
Impacted Files Coverage Δ
nodebuilder/gateway/gateway.go 0.00% <0.00%> (ø)
nodebuilder/module.go 100.00% <ø> (ø)
nodebuilder/node.go 60.31% <ø> (ø)
nodebuilder/gateway/module.go 15.78% <15.78%> (ø)
api/gateway/server.go 66.66% <58.82%> (-2.23%) ⬇️
nodebuilder/gateway/config.go 62.50% <62.50%> (ø)
cmd/celestia/full.go 38.02% <66.66%> (+1.26%) ⬆️
cmd/celestia/light.go 37.50% <66.66%> (+1.26%) ⬆️
api/rpc/server.go 75.00% <70.58%> (-7.15%) ⬇️
nodebuilder/gateway/flags.go 75.67% <75.67%> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@distractedm1nd distractedm1nd marked this pull request as draft October 6, 2022 15:54
@distractedm1nd
Copy link
Member Author

Converted to draft, only because the PR it is based on is also in draft

@distractedm1nd distractedm1nd linked an issue Oct 7, 2022 that may be closed by this pull request
@distractedm1nd distractedm1nd marked this pull request as ready for review October 7, 2022 12:51
@distractedm1nd distractedm1nd changed the title feat(gateway): reenabling gateway, disabled by default feat(gateway): reenabling gateway, adding flag to enable Oct 7, 2022
@distractedm1nd distractedm1nd force-pushed the gateway-flag branch 3 times, most recently from 01e96e1 to cc0838b Compare October 26, 2022 07:45
nodebuilder/gateway/flags.go Show resolved Hide resolved
nodebuilder/gateway/rpc.go Outdated Show resolved Hide resolved
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

g: Sanitize all the comments on the RPC and gateway

api/gateway/server.go Outdated Show resolved Hide resolved
nodebuilder/gateway/config.go Outdated Show resolved Hide resolved
nodebuilder/gateway/module.go Outdated Show resolved Hide resolved
nodebuilder/gateway/module.go Show resolved Hide resolved
api/gateway/server.go Outdated Show resolved Hide resolved
api/gateway/server_test.go Outdated Show resolved Hide resolved
api/gateway/server.go Outdated Show resolved Hide resolved
api/gateway/server.go Outdated Show resolved Hide resolved
api/gateway/server.go Outdated Show resolved Hide resolved
api/gateway/server.go Outdated Show resolved Hide resolved
api/rpc/server.go Outdated Show resolved Hide resolved
api/rpc/server.go Outdated Show resolved Hide resolved
nodebuilder/gateway/flags.go Show resolved Hide resolved
nodebuilder/gateway/flags.go Outdated Show resolved Hide resolved
renaynay
renaynay previously approved these changes Oct 28, 2022
Wondertan
Wondertan previously approved these changes Oct 28, 2022
renaynay
renaynay previously approved these changes Oct 28, 2022
@distractedm1nd distractedm1nd merged commit c537ec4 into celestiaorg:main Oct 28, 2022
@Wondertan Wondertan deleted the gateway-flag branch October 28, 2022 14:01
@renaynay renaynay added kind:break! Attached to breaking PRs and removed kind:feat Attached to feature PRs labels Oct 31, 2022
@renaynay renaynay changed the title feat(gateway): reenabling gateway, adding flag to enable feat!(gateway): reenabling gateway, adding flag to enable Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rpc kind:break! Attached to breaking PRs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Enable gateway with flag Reintroduce REST gateway Reintroduce REST gateway with most frequent endpoints
4 participants