Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(share): move bad encoding fraud proof to share pkg #1241

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

walldiss
Copy link
Member

Resolves #1100

@walldiss walldiss self-assigned this Oct 18, 2022
@walldiss walldiss changed the title move bad encoding fraud proof to share pkg refactor(share): move bad encoding fraud proof to share pkg Oct 18, 2022
@walldiss walldiss force-pushed the move_befp_to_share branch 2 times, most recently from 2a61787 to bf7535d Compare October 25, 2022 11:45
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022

Codecov Report

Merging #1241 (e26ed96) into main (f4e582e) will decrease coverage by 0.59%.
The diff coverage is 46.59%.

@@            Coverage Diff             @@
##             main    #1241      +/-   ##
==========================================
- Coverage   56.34%   55.75%   -0.60%     
==========================================
  Files         160      164       +4     
  Lines        9935    10046     +111     
==========================================
+ Hits         5598     5601       +3     
- Misses       3783     3887     +104     
- Partials      554      558       +4     
Impacted Files Coverage Δ
fraud/pb/proof.pb.go 34.71% <0.00%> (-1.90%) ⬇️
share/eds/byzantine/byzantine.go 69.23% <ø> (ø)
share/get.go 90.32% <ø> (+9.07%) ⬆️
share/share.go 100.00% <ø> (ø)
share/eds/byzantine/pb/share.pb.go 32.88% <33.67%> (ø)
share/eds/byzantine/share_proof.go 88.88% <88.88%> (ø)
das/daser.go 66.27% <100.00%> (ø)
fraud/testing.go 90.27% <100.00%> (+3.00%) ⬆️
share/eds/byzantine/bad_encoding.go 63.00% <100.00%> (ø)
share/eds/retriever.go 91.97% <100.00%> (ø)
... and 35 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@walldiss walldiss marked this pull request as ready for review October 25, 2022 11:53
das/daser.go Outdated Show resolved Hide resolved
share/eds/byzantine/pb/share.proto Outdated Show resolved Hide resolved
share/eds/byzantine/pb/share.proto Outdated Show resolved Hide resolved
share/eds/byzantine/share_proof.go Outdated Show resolved Hide resolved
share/eds/byzantine/pb/share.proto Outdated Show resolved Hide resolved
@walldiss walldiss merged commit ff35df8 into celestiaorg:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:shares Shares and samples
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

fraud: Move BEFP definitions to share pkg
5 participants