feat(ipld): integration test for namespace hasher #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1256 +/- ##
==========================================
- Coverage 56.16% 55.74% -0.42%
==========================================
Files 161 163 +2
Lines 9880 10027 +147
==========================================
+ Hits 5549 5590 +41
- Misses 3781 3880 +99
- Partials 550 557 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MSevey
requested changes
Oct 20, 2022
renaynay
reviewed
Oct 21, 2022
There was a problem hiding this comment.
-
can we call
nmt_hasher_test.goand we can just, in the docs forTestNamespaceHasher_CorruptedData, explain that it's an integration test, etc. This will get run as part of unit testing though (unless we put it in swamp tests) -
another nit, I prefer to have test functions first and all mocks used in those test functions defined below
-
additionally noticed
SubNetNodeis dangling
renaynay
reviewed
Oct 24, 2022
…nd renaming test file
MSevey
reviewed
Oct 24, 2022
MSevey
requested changes
Oct 24, 2022
MSevey
previously approved these changes
Oct 24, 2022
renaynay
reviewed
Oct 25, 2022
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Wondertan
previously approved these changes
Oct 26, 2022
Wondertan
approved these changes
Oct 26, 2022
renaynay
approved these changes
Oct 26, 2022
walldiss
reviewed
Oct 26, 2022
| } | ||
|
|
||
| func (b *CorruptBlock) String() string { | ||
| return fmt.Sprintf("[Block %s]", b.Cid()) |
There was a problem hiding this comment.
Suggested change
| return fmt.Sprintf("[Block %s]", b.Cid()) | |
| return fmt.Sprintf("[Block %s]", b.Cid().String()) |
Comment on lines
+115
to
+117
| lights1, lights2 := make( | ||
| []*availability_test.TestNode, lightNodes/2), | ||
| make([]*availability_test.TestNode, lightNodes/2) |
There was a problem hiding this comment.
Nit: Personally for me it is much harder to read code as 3 line like that than if it was 2 lines:
Suggested change
| lights1, lights2 := make( | |
| []*availability_test.TestNode, lightNodes/2), | |
| make([]*availability_test.TestNode, lightNodes/2) | |
| lights1 := make([]*availability_test.TestNode, lightNodes/2) | |
| lights2 := make([]*availability_test.TestNode, lightNodes/2) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1249