Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nodebuilder): Allow custom networks to work over already-initialised store #1270

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

renaynay
Copy link
Member

After conversation with @jbowen93 , we decided to allow using custom networks over an already-initialised node store.

The issue this was originally attempting to prevent is accidental corruption of chain data in the case that a user accidentally leaves their environment variable set up and connects to another network over an old node store.

This issue is actually currently prevented thanks to #1073 extending the node store name with the network name.

Wondertan
Wondertan previously approved these changes Oct 24, 2022
jbowen93
jbowen93 previously approved these changes Oct 24, 2022
distractedm1nd
distractedm1nd previously approved these changes Oct 24, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1270 (3caad63) into main (0e48f9a) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1270      +/-   ##
==========================================
- Coverage   56.17%   56.15%   -0.02%     
==========================================
  Files         160      160              
  Lines        9939     9935       -4     
==========================================
- Hits         5583     5579       -4     
  Misses       3802     3802              
  Partials      554      554              
Impacted Files Coverage Δ
nodebuilder/init.go 65.71% <ø> (+2.20%) ⬆️
header/core/listener.go 52.83% <0.00%> (-5.67%) ⬇️
share/ipld/get.go 92.59% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@renaynay renaynay merged commit f4e582e into celestiaorg:main Oct 24, 2022
@renaynay renaynay deleted the remove-error-customnet-init branch October 24, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants