Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): adding daser stub for friendly API error #1308

Merged
merged 4 commits into from
Nov 3, 2022

Conversation

distractedm1nd
Copy link
Member

@distractedm1nd distractedm1nd commented Nov 1, 2022

Closes #1299 and #304

@codecov-commenter
Copy link

Codecov Report

Merging #1308 (59809a5) into main (f5f5adb) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1308      +/-   ##
==========================================
+ Coverage   54.83%   55.07%   +0.24%     
==========================================
  Files         176      176              
  Lines       10552    10545       -7     
==========================================
+ Hits         5786     5808      +22     
+ Misses       4194     4159      -35     
- Partials      572      578       +6     
Impacted Files Coverage Δ
nodebuilder/das/mocks/api.go 26.66% <ø> (ø)
nodebuilder/fraud/mocks/api.go 12.50% <ø> (ø)
nodebuilder/header/mocks/api.go 12.50% <ø> (ø)
nodebuilder/node.go 60.31% <ø> (ø)
nodebuilder/share/mocks/api.go 8.16% <ø> (ø)
nodebuilder/state/mocks/api.go 11.45% <ø> (ø)
nodebuilder/das/daser.go 100.00% <100.00%> (ø)
nodebuilder/das/module.go 95.12% <100.00%> (+0.52%) ⬆️
nodebuilder/rpc/module.go 91.66% <100.00%> (-2.93%) ⬇️
nodebuilder/rpc/rpc.go 100.00% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

nodebuilder/das/daser.go Outdated Show resolved Hide resolved
walldiss
walldiss previously approved these changes Nov 2, 2022
renaynay
renaynay previously approved these changes Nov 2, 2022
nodebuilder/node_bridge_test.go Outdated Show resolved Hide resolved
@distractedm1nd distractedm1nd merged commit bcad107 into celestiaorg:main Nov 3, 2022
@distractedm1nd distractedm1nd deleted the daser-stub branch November 3, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide DASer stub on bridge node
5 participants