feat: add local docker telemetry infrastructure #1990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrandz
requested review from
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1990 +/- ##
==========================================
+ Coverage 54.12% 54.32% +0.19%
==========================================
Files 216 216
Lines 14081 14081
==========================================
+ Hits 7622 7649 +27
+ Misses 5645 5619 -26
+ Partials 814 813 -1 see 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
renaynay
reviewed
Mar 31, 2023
Comment on lines
+176
to
+190
| ## check-docker: Check if docker is installed on the machine | ||
| check-docker: | ||
| ifeq (,$(shell which docker)) | ||
| @echo "docker is not installed, you must install docker first." | ||
| exit 1; | ||
| endif | ||
| .PHONY: check-go | ||
|
|
||
| ## check-docker: Check if docker is installed on the machine | ||
| check-docker-compose: | ||
| ifeq (,$(shell which docker-compose)) | ||
| @echo "docker-compose is not installed, you must install it first." | ||
| exit 1; | ||
| endif | ||
| .PHONY: check-go |
|
Replaced by #2296 |
distractedm1nd
added a commit
that referenced
this pull request
Sep 4, 2023
Supersedes #1990 Adds local telemetry infra to the Makefile. This includes pyroscope, grafana, jaeger, an otel-collector, prometheus, and loki. --------- Co-authored-by: derrandz <ouaghad.hamza@gmail.com> Co-authored-by: ramin <raminkeene@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds local docker telemetry infrastructure, instructions to run the infrastructure are in the
README.mdChecklist