refactor(libs/fraud): fraud tests overhaul #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
requested review from
renaynay,
vgonkivs,
distractedm1nd and
walldiss
as code owners
Wondertan
added
kind:refactor
The main goal here is to prepare everything for extraction. There was a cyclic dependency and dependance on ExtendedHeader inside of `fraud` which blocked the extraction. This patch fixes this in conjuction with cleanings for testing utilies and actual tests. Other list of notable changes: * Updates go-header * Restuctures fraud pkg and extract fraud.Service into sub pkg fraudserv * Extracts testing utilities into fraudtest * Adds sprinkles of documentation
Wondertan
force-pushed
the
hlib/bump-go-header
branch
from
9c20391
to
3b8842a
Compare
Codecov Report
@@ Coverage Diff @@
## main #2039 +/- ##
==========================================
- Coverage 54.41% 54.17% -0.24%
==========================================
Files 216 217 +1
Lines 14057 13991 -66
==========================================
- Hits 7649 7580 -69
- Misses 5582 5583 +1
- Partials 826 828 +2
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
renaynay
approved these changes
Apr 11, 2023
This was referenced Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal here is to prepare everything for extraction. There was a cyclic dependency and dependence on ExtendedHeader inside of
fraud, which blocked the extraction. This patch fixes this in conjunction with cleanings for testing utilities and actual tests.List of other notable changes:
headerfraud.Serviceand related logic into sub pkgfraudservfraudfraudtest