feat(share/getter): add support for ErrNotFound in shrex getter implementation #2073
Conversation
- add support in ipld getter - add support in store getter
walldiss
added
area:shares
|
|
||
| fmt.Println(car.HeaderSize(carReader.Header)) |
There was a problem hiding this comment.
just a sneaky cleanup. Didn't want to make an extra PR for that
| // validate will collect peer.ID into corresponding peer pool | ||
| func (m *Manager) validate(_ context.Context, peerID peer.ID, msg shrexsub.Notification) pubsub.ValidationResult { | ||
| // Validate will collect peer.ID into corresponding peer pool | ||
| func (m *Manager) Validate(_ context.Context, peerID peer.ID, msg shrexsub.Notification) pubsub.ValidationResult { |
There was a problem hiding this comment.
Exported to allow adding peers in tests. Not super clean solution, I'm open for other suggestions how to populate peer manager with test peers.
There was a problem hiding this comment.
Fine to me, as long as we consider migrating over to messenger in short term, which will fix this
walldiss
force-pushed
the
shrex_err_not_found
branch
from
7ddb7d7
to
9335ff1
Compare
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
share/getters/shrex.go
Outdated
| case p2p.ErrInvalidResponse: | ||
| case errors.Is(getErr, context.DeadlineExceeded), | ||
| errors.Is(getErr, context.Canceled): | ||
| case errors.Is(getErr, p2p.ErrUnavailable): |
There was a problem hiding this comment.
Why is it called unavailable?
There was a problem hiding this comment.
We've had this discussion before - its unavailable because it means we don't have it at the moment (but may have it in a few seconds)
There was a problem hiding this comment.
I've renamed it to ErrNotFound to make it consistent to other errs in out codebase.
|
For some reason this one doesn't track pushes to the source branch anymore. Closing in favour of new one #2074 |
Overview
Resolves #2037