Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shrex): metrics #2095

Merged
merged 12 commits into from
May 3, 2023
Merged

Conversation

distractedm1nd
Copy link
Member

@distractedm1nd distractedm1nd commented Apr 18, 2023

Closes #2143
Adds metrics to ShrexGetter, and ShrexEDS/ShrexND Client and Server (including shrex middleware)

@distractedm1nd distractedm1nd self-assigned this Apr 21, 2023
@distractedm1nd distractedm1nd added kind:feat Attached to feature PRs area:metrics Related to measuring/collecting node metrics labels Apr 28, 2023
@distractedm1nd distractedm1nd marked this pull request as ready for review April 28, 2023 05:19
share/getters/shrex.go Outdated Show resolved Hide resolved
share/p2p/middleware.go Outdated Show resolved Hide resolved
share/p2p/shrexeds/client.go Outdated Show resolved Hide resolved
share/p2p/shrexeds/server.go Outdated Show resolved Hide resolved
@distractedm1nd distractedm1nd marked this pull request as draft April 28, 2023 06:00
@distractedm1nd distractedm1nd changed the title feat(share/p2p/shrexeds): metrics feat(shrex): metrics Apr 28, 2023
@distractedm1nd distractedm1nd marked this pull request as ready for review April 28, 2023 06:43
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023

Codecov Report

Merging #2095 (1172b73) into main (5c0b128) will increase coverage by 0.52%.
The diff coverage is 73.54%.

@@            Coverage Diff             @@
##             main    #2095      +/-   ##
==========================================
+ Coverage   55.44%   55.96%   +0.52%     
==========================================
  Files         212      213       +1     
  Lines       13576    13846     +270     
==========================================
+ Hits         7527     7749     +222     
- Misses       5286     5325      +39     
- Partials      763      772       +9     
Impacted Files Coverage Δ
cmd/celestia/rpc.go 11.44% <0.00%> (-0.35%) ⬇️
nodebuilder/share/opts.go 62.50% <57.14%> (-37.50%) ⬇️
share/p2p/shrexeds/client.go 64.00% <57.14%> (-0.52%) ⬇️
share/p2p/shrexeds/params.go 62.50% <57.14%> (-7.50%) ⬇️
share/p2p/shrexnd/params.go 62.50% <57.14%> (-37.50%) ⬇️
share/p2p/shrexnd/server.go 66.89% <68.75%> (-0.03%) ⬇️
share/getters/shrex.go 81.25% <70.00%> (-4.33%) ⬇️
share/p2p/metrics.go 70.96% <70.96%> (ø)
share/p2p/shrexnd/client.go 68.00% <71.42%> (-0.34%) ⬇️
share/p2p/shrexeds/server.go 65.57% <72.72%> (+0.39%) ⬆️
... and 8 more

... and 3 files with indirect coverage changes

Wondertan
Wondertan previously approved these changes Apr 28, 2023
nodebuilder/settings.go Outdated Show resolved Hide resolved
share/getters/shrex.go Outdated Show resolved Hide resolved
share/getters/shrex.go Outdated Show resolved Hide resolved
share/getters/shrex.go Outdated Show resolved Hide resolved
share/getters/shrex.go Outdated Show resolved Hide resolved
share/p2p/middleware.go Outdated Show resolved Hide resolved
share/p2p/metrics.go Outdated Show resolved Hide resolved
share/getters/shrex.go Outdated Show resolved Hide resolved
share/p2p/middleware.go Outdated Show resolved Hide resolved
renaynay
renaynay previously approved these changes May 3, 2023
renaynay
renaynay previously approved these changes May 3, 2023
share/p2p/metrics.go Outdated Show resolved Hide resolved
share/getters/shrex.go Outdated Show resolved Hide resolved
share/p2p/metrics.go Outdated Show resolved Hide resolved
renaynay
renaynay previously approved these changes May 3, 2023
share/p2p/shrexeds/server.go Outdated Show resolved Hide resolved
share/p2p/shrexeds/client.go Outdated Show resolved Hide resolved
share/p2p/shrexeds/client.go Outdated Show resolved Hide resolved
share/getters/shrex.go Outdated Show resolved Hide resolved
share/getters/shrex.go Outdated Show resolved Hide resolved
@distractedm1nd distractedm1nd merged commit 4d31ad4 into celestiaorg:main May 3, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Related to measuring/collecting node metrics kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(shrex): metrics for shrex server and shrex middleware
5 participants