-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shrex): metrics #2095
Merged
distractedm1nd
merged 12 commits into
celestiaorg:main
from
distractedm1nd:shrexeds-metrics
May 3, 2023
Merged
feat(shrex): metrics #2095
distractedm1nd
merged 12 commits into
celestiaorg:main
from
distractedm1nd:shrexeds-metrics
May 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5cd37fb
to
cfc4127
Compare
Wondertan
reviewed
Apr 28, 2023
Wondertan
reviewed
Apr 28, 2023
Codecov Report
@@ Coverage Diff @@
## main #2095 +/- ##
==========================================
+ Coverage 55.44% 55.96% +0.52%
==========================================
Files 212 213 +1
Lines 13576 13846 +270
==========================================
+ Hits 7527 7749 +222
- Misses 5286 5325 +39
- Partials 763 772 +9
|
Wondertan
previously approved these changes
Apr 28, 2023
renaynay
reviewed
Apr 28, 2023
27c63dd
to
7ef47a3
Compare
walldiss
reviewed
May 3, 2023
renaynay
previously approved these changes
May 3, 2023
renaynay
previously approved these changes
May 3, 2023
221bf8a
to
f337f3e
Compare
walldiss
requested changes
May 3, 2023
renaynay
previously approved these changes
May 3, 2023
walldiss
reviewed
May 3, 2023
walldiss
reviewed
May 3, 2023
walldiss
approved these changes
May 3, 2023
1e53a13
to
1172b73
Compare
renaynay
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2143
Adds metrics to ShrexGetter, and ShrexEDS/ShrexND Client and Server (including shrex middleware)