Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(share/shrex): improve shrex logging #2101

Merged
merged 4 commits into from
Apr 20, 2023

Conversation

walldiss
Copy link
Member

Overview

  • Previously shrex-nd and shrex-eds error logs were indistinguishable, that lead to confusion of errors source.
  • add peerID to server logs
  • Improve some other shrex logging.

Resolves #2035

@walldiss walldiss added area:shares Shares and samples kind:refactor Attached to refactoring PRs labels Apr 19, 2023
@walldiss walldiss self-assigned this Apr 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Merging #2101 (c4601b7) into main (bbe68bb) will decrease coverage by 0.04%.
The diff coverage is 70.32%.

@@            Coverage Diff             @@
##             main    #2101      +/-   ##
==========================================
- Coverage   55.71%   55.68%   -0.04%     
==========================================
  Files         209      209              
  Lines       13270    13312      +42     
==========================================
+ Hits         7394     7413      +19     
- Misses       5132     5156      +24     
+ Partials      744      743       -1     
Impacted Files Coverage Δ
share/p2p/middleware.go 80.00% <0.00%> (ø)
share/p2p/shrexnd/client.go 62.50% <50.00%> (ø)
share/p2p/shrexnd/server.go 66.92% <52.17%> (+0.51%) ⬆️
share/p2p/shrexeds/server.go 65.17% <65.00%> (+0.95%) ⬆️
share/p2p/peers/manager.go 77.48% <77.77%> (-0.30%) ⬇️
share/p2p/shrexeds/client.go 60.52% <83.33%> (+1.62%) ⬆️
share/getters/shrex.go 87.75% <100.00%> (ø)
share/p2p/peers/pool.go 95.00% <100.00%> (+0.17%) ⬆️

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

share/p2p/peers/pool.go Outdated Show resolved Hide resolved
share/p2p/shrexeds/server.go Show resolved Hide resolved
share/p2p/shrexnd/client.go Outdated Show resolved Hide resolved
share/p2p/shrexnd/server.go Show resolved Hide resolved
share/p2p/shrexnd/server.go Show resolved Hide resolved
@walldiss walldiss enabled auto-merge (squash) April 20, 2023 12:57
@walldiss walldiss merged commit c4e994b into celestiaorg:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:shares Shares and samples kind:refactor Attached to refactoring PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(share/p2p/shrexnd): Request from light node to blockspacerace for GetSharesByNamespace hangs forever
4 participants