fix(gateway): deescalating log in gateway's writeErr #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distractedm1nd
added
kind:fix
distractedm1nd
requested review from
Wondertan,
vgonkivs and
walldiss
as code owners
Wondertan
approved these changes
Apr 28, 2023
Codecov Report
@@ Coverage Diff @@
## main #2142 +/- ##
==========================================
- Coverage 55.63% 55.44% -0.20%
==========================================
Files 212 212
Lines 13571 13571
==========================================
- Hits 7550 7524 -26
- Misses 5258 5283 +25
- Partials 763 764 +1
|
renaynay
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2141
writeError is called by almost all gateway endpoints. If a client makes a request for bad data, that is not an error for the server - but still useful as a debug log.