fix(nodebuilder): fix error log and shut the fx #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
commented
May 3, 2023
Codecov Report
@@ Coverage Diff @@
## main #2160 +/- ##
==========================================
- Coverage 56.12% 55.96% -0.16%
==========================================
Files 213 213
Lines 13846 13847 +1
==========================================
- Hits 7771 7750 -21
- Misses 5303 5325 +22
Partials 772 772
|
Wondertan
requested review from
renaynay,
vgonkivs,
distractedm1nd and
walldiss
as code owners
distractedm1nd
approved these changes
May 3, 2023
renaynay
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Granular change descriptions are in comments