Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(share/discovery): fixes from Advertise logic audit #2163

Merged
merged 2 commits into from
May 4, 2023
Merged

fix(share/discovery): fixes from Advertise logic audit #2163

merged 2 commits into from
May 4, 2023

Conversation

Wondertan
Copy link
Member

  • Use only TTL provided by us.
  • Don't wait 8hs upon error
  • Increase the advertise timeout

@Wondertan Wondertan added area:shares Shares and samples kind:fix Attached to bug-fixing PRs labels May 4, 2023
@Wondertan Wondertan requested a review from renaynay as a code owner May 4, 2023 09:57
@Wondertan Wondertan self-assigned this May 4, 2023
@Wondertan Wondertan enabled auto-merge (squash) May 4, 2023 09:59
walldiss
walldiss reviewed May 4, 2023
View reviewed changes
share/availability/discovery/discovery.go Outdated Show resolved Hide resolved
share/availability/discovery/discovery.go Outdated Show resolved Hide resolved
@Wondertan Wondertan merged commit 0100141 into main May 4, 2023
16 of 17 checks passed
@Wondertan Wondertan deleted the hlib/audit-advertise branch May 4, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walldiss walldiss walldiss left review comments

@vgonkivs vgonkivs vgonkivs approved these changes

@renaynay renaynay renaynay approved these changes

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd distractedm1nd is a code owner

Assignees

@Wondertan Wondertan

Labels
area:shares Shares and samples kind:fix Attached to bug-fixing PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Wondertan @walldiss @vgonkivs @renaynay