Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics): set build info as an attribute in metrics #2165

Merged
merged 4 commits into from
May 5, 2023
Merged

feat(metrics): set build info as an attribute in metrics #2165

merged 4 commits into from
May 5, 2023

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented May 4, 2023 •
edited
Loading

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs added kind:feat Attached to feature PRs area:metrics Related to measuring/collecting node metrics labels May 4, 2023
@vgonkivs vgonkivs self-assigned this May 4, 2023
@vgonkivs vgonkivs force-pushed the set_build_info_in_metrics branch from 0720533 to 3dbdb48 Compare May 4, 2023 12:29
Wondertan
Wondertan reviewed May 4, 2023
View reviewed changes
nodebuilder/settings.go Outdated Show resolved Hide resolved
cmd/celestia/util.go Outdated Show resolved Hide resolved
mojtaba-esk
mojtaba-esk previously approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@mojtaba-esk mojtaba-esk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgonkivs vgonkivs force-pushed the set_build_info_in_metrics branch from 3dbdb48 to d06913b Compare May 5, 2023 09:05
@vgonkivs vgonkivs marked this pull request as ready for review May 5, 2023 09:10
distractedm1nd
distractedm1nd previously approved these changes May 5, 2023
View reviewed changes
Wondertan
Wondertan previously approved these changes May 5, 2023
View reviewed changes
renaynay
renaynay previously approved these changes May 5, 2023
View reviewed changes
nodebuilder/config.go Outdated Show resolved Hide resolved
@vgonkivs vgonkivs dismissed stale reviews from renaynay, Wondertan, and distractedm1nd via d6db209 May 5, 2023 11:45
@vgonkivs vgonkivs enabled auto-merge (squash) May 5, 2023 15:32
@vgonkivs vgonkivs merged commit 929a334 into celestiaorg:main May 5, 2023
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan left review comments

@derrandz derrandz derrandz approved these changes

@renaynay renaynay renaynay approved these changes

@mojtaba-esk mojtaba-esk mojtaba-esk left review comments

@distractedm1nd distractedm1nd distractedm1nd left review comments

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees

@vgonkivs vgonkivs

Labels
area:metrics Related to measuring/collecting node metrics kind:feat Attached to feature PRs
Projects
No open projects
Celestia Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vgonkivs @derrandz @mojtaba-esk @distractedm1nd @Wondertan @renaynay