Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Makefile): add fetch tags action #2167

Closed
wants to merge 4 commits into from
Closed

feat(Makefile): add fetch tags action #2167

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68eda26
feat(Makefile): add fetch tags action
vgonkivs May 5, 2023
962361a
chore(Makefile): remove all tag
vgonkivs May 5, 2023
9a0d544
chore(Makefile): remove target
vgonkivs May 5, 2023
e9d8685
test
vgonkivs May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ install-hooks:
.PHONY: init-hooks

## build: Build celestia-node binary.
build:
build: fetch-tags
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove fetch-tags from every other target?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the build only contain it?

Then it is no sense to have target

@echo "--> Building Celestia"
@go build -o build/ ${LDFLAGS} ./cmd/celestia
.PHONY: build
Expand All @@ -41,13 +41,13 @@ deps:
.PHONY: deps

## install: Install all build binaries into the $PREFIX (/usr/local/ by default) directory.
install:
install: fetch-tags
@echo "--> Installing Celestia"
@install -v ./build/* -t ${PREFIX}/bin/
.PHONY: install

## go-install: Build and install the celestia-node binary into the GOBIN directory.
go-install:
go-install: fetch-tags
@echo "--> Installing Celestia"
@go install ${LDFLAGS} ./cmd/celestia
.PHONY: go-install
Expand Down Expand Up @@ -93,6 +93,12 @@ lint: lint-imports
@cfmt -m=100 ./...
.PHONY: lint

## fetch-tags: Fetching all tags
fetch-tags:
@echo "--> Fetching all tags"
@git fetch --tags
.PHONY: fetch-tags

## test-unit: Running unit tests
test-unit:
@echo "--> Running unit tests"
Expand Down
Loading