Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(share/p2p/shrexeds): return correct err on context error #2177

Merged
merged 1 commit into from
May 10, 2023

Conversation

derrandz
Copy link
Contributor

@derrandz derrandz commented May 9, 2023

Overview

Resolves item 7 on #2176

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@derrandz derrandz marked this pull request as ready for review May 9, 2023 15:25
@codecov-commenter
Copy link

Codecov Report

Merging #2177 (0371e52) into main (7f556f0) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2177      +/-   ##
==========================================
- Coverage   56.04%   55.89%   -0.15%     
==========================================
  Files         215      215              
  Lines       13918    13918              
==========================================
- Hits         7800     7780      -20     
- Misses       5340     5359      +19     
- Partials      778      779       +1     
Impacted Files Coverage Δ
share/p2p/shrexeds/client.go 64.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

@Wondertan
Copy link
Member

It's a fix not a chore though

@distractedm1nd distractedm1nd changed the title chore: return correct err fix(share/p2p/shrexeds): return correct err on context error May 10, 2023
@distractedm1nd distractedm1nd added area:shares Shares and samples kind:fix Attached to bug-fixing PRs labels May 10, 2023
@distractedm1nd distractedm1nd merged commit a57ad56 into celestiaorg:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:shares Shares and samples kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants