Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(daser): persist retry count after restart #2185

Merged
merged 3 commits into from
May 11, 2023

Conversation

walldiss
Copy link
Member

Overview

If job was being handled by retry worker on node shutdown the retry backoff counter would be lost after restart.

@walldiss walldiss added kind:fix Attached to bug-fixing PRs area:das Related to DASer labels May 10, 2023
@walldiss walldiss self-assigned this May 10, 2023
@walldiss walldiss force-pushed the daser_expose_unavailable_counter branch from c346d81 to afcb407 Compare May 10, 2023 13:34
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one Q

das/worker.go Show resolved Hide resolved
das/coordinator_test.go Outdated Show resolved Hide resolved
das/state.go Show resolved Hide resolved
das/worker.go Show resolved Hide resolved
Copy link
Contributor

@derrandz derrandz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smoll improvement

das/state.go Outdated Show resolved Hide resolved
@walldiss walldiss requested a review from Wondertan May 11, 2023 13:39
@Wondertan Wondertan enabled auto-merge (squash) May 11, 2023 14:58
@Wondertan Wondertan merged commit 876c6d0 into celestiaorg:main May 11, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:das Related to DASer kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants