Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nodebuilder/header): Add WaitForHeight endpoint #2201

Merged
merged 2 commits into from
May 16, 2023
Merged

feat(nodebuilder/header): Add WaitForHeight endpoint #2201

merged 2 commits into from
May 16, 2023

Conversation

renaynay
Copy link
Member

AddsWaitForHeight endpoint which was formerly GetByHeight that just exposes store.GetByHeight

@renaynay renaynay added area:header Extended header kind:feat Attached to feature PRs labels May 15, 2023
@renaynay renaynay self-assigned this May 15, 2023
@renaynay renaynay added the area:api Related to celestia-node API label May 15, 2023
Wondertan
Wondertan reviewed May 15, 2023
View reviewed changes
docs/adr/adr-009-public-api.md Outdated Show resolved Hide resolved
nodebuilder/header/header.go Show resolved Hide resolved
Wondertan
Wondertan previously approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as my doc comment is nit

@codecov-commenter
Copy link

Codecov Report

Merging #2201 (d7db6ae) into main (2fa72c7) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2201      +/-   ##
==========================================
- Coverage   55.84%   55.74%   -0.10%     
==========================================
  Files         216      216              
  Lines       14106    14110       +4     
==========================================
- Hits         7877     7866      -11     
- Misses       5442     5456      +14     
- Partials      787      788       +1
Impacted Files Coverage Δ
nodebuilder/header/header.go 11.11% <0.00%> (-1.39%) ⬇️
nodebuilder/header/service.go 13.11% <0.00%> (-0.45%) ⬇️

... and 2 files with indirect coverage changes

@renaynay renaynay merged commit 3b62c6b into celestiaorg:main May 16, 2023
12 of 14 checks passed
@renaynay renaynay deleted the wait-for-height branch May 16, 2023 08:28
vgonkivs pushed a commit to vgonkivs/celestia-node that referenced this pull request May 22, 2023
@renaynay @vgonkivs
feat(nodebuilder/header): Add WaitForHeight endpoint (celestiaorg#2201
56a00fe 
)

Adds`WaitForHeight` endpoint which was formerly `GetByHeight` that just
exposes store.GetByHeight
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamsi liamsi liamsi approved these changes

@Wondertan Wondertan Wondertan approved these changes

@vgonkivs vgonkivs vgonkivs approved these changes

@adlerjohn adlerjohn Awaiting requested review from adlerjohn adlerjohn is a code owner

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd distractedm1nd is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees

@renaynay renaynay

Labels
area:api Related to celestia-node API area:header Extended header kind:feat Attached to feature PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@renaynay @codecov-commenter @liamsi @Wondertan @vgonkivs