Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Genesis: The PR to make testnet happen! #221

Merged
merged 50 commits into from
Nov 22, 2021
Merged

Genesis: The PR to make testnet happen! #221

merged 50 commits into from
Nov 22, 2021

Conversation

Wondertan
Copy link
Member

@Wondertan Wondertan commented Nov 19, 2021 •
edited
Loading

Changes

  • Flags added to init and start:
    • headers.genesis-hash
    • headers.trusted-peer
    • node.config

@Wondertan Wondertan self-assigned this Nov 19, 2021
renaynay
renaynay previously approved these changes Nov 19, 2021
View reviewed changes
cmd/init.go Show resolved Hide resolved
cmd/init.go Show resolved Hide resolved
node/services/service.go Show resolved Hide resolved
service/header/p2p_exchange.go Outdated Show resolved Hide resolved
service/header/p2p_exchange.go Show resolved Hide resolved
service/header/sync.go Show resolved Hide resolved
service/header/sync.go Outdated Show resolved Hide resolved
renaynay
renaynay previously approved these changes Nov 19, 2021
View reviewed changes
renaynay and others added 22 commits November 19, 2021 12:12
@renaynay @Wondertan
prog
dfc7b13
@renaynay @Wondertan
fix testsubscriber
742abd2
@renaynay @Wondertan
provide head bytes
1f01b98
@renaynay @Wondertan
update description
ca058c9
@renaynay @Wondertan
dependencies on node
8d6d6b0
@Wondertan
fix(core): make BlockFetcher return errors in case of an error and fu…
98c6e4c 
…ck Tendermint API
@Wondertan
feat(core): new RepoLoader func not avoid cycles
04c2b90
@Wondertan
feat|deps(node): update FX and new utilities to work with it
30713d4
@Wondertan
ref(service/heaeder): rename Exchange to P2PExchange
40bde4c
@Wondertan
ref(service/header): remove not generic Start/Stop from Exchange inte…
49b5ba3 
…rface
@Wondertan
ref(service/header): extract Syncer into public type and make it also…
a150270 
… fetch genesis
@Wondertan
fix(node/p2p): remove filling bootstrap peers into DI - was a bad idea
e4261c3
@Wondertan
feat(node/services): introduce sub Config for services with Genesis a…
42cce14 
…nd TrustPeer
@Wondertan
ref(node/services): prettify and update services constractng
f519275
@Wondertan
ref(node): extract common components into baseComponents and put all …
c65f5b4 
…the components referencing into one file for readability
@Wondertan
ref(node): remove ugly RPC starting and subsequently itself with test…
38fc5b4 
…s; make DASer optional
@Wondertan
fix(cmd): swap head with genesis in start flag
a24d61f
@Wondertan
ref|fix(service/header): remove Open from Store and make Head try to …
42cc471 
…read the header if it is not present
@Wondertan
logs(service/headers): improve logging for exchange
9d9a8df
@Wondertan
make fmt
599824c
@Wondertan
fix(node): use proper var for genesis hash requesting
864e9f8
@Wondertan
fix(service/header): fix append to return
e73d1da
@liamsi liamsi mentioned this pull request Nov 20, 2021
Closed
@Wondertan Wondertan changed the title cmd: More flags to start and init Genesis: The PR to make testnet happen! Nov 22, 2021
@liamsi
Copy link
Member

liamsi commented Nov 22, 2021 •
edited
Loading

Are we taking any shortcuts here? If not, I'd say let's merge it to unblock devnet and I'll review it properly next week!

@renaynay renaynay mentioned this pull request Nov 22, 2021
Closed
renaynay
renaynay approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets merge this behemoth of a PR

liamsi
liamsi approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
but seriously: #226

@Wondertan Wondertan merged commit fd9f15b into main Nov 22, 2021
@Wondertan Wondertan deleted the hlib/flags branch November 22, 2021 16:15
@liamsi liamsi mentioned this pull request Aug 16, 2021
Closed
10 tasks
@Wondertan Wondertan restored the hlib/flags branch January 7, 2022 14:40
@Wondertan Wondertan deleted the hlib/flags branch January 7, 2022 15:57
@liamsi liamsi mentioned this pull request Apr 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamsi liamsi liamsi approved these changes

@renaynay renaynay renaynay approved these changes

@jbowen93 jbowen93 jbowen93 left review comments

@mattdf mattdf Awaiting requested review from mattdf

Assignees

@Wondertan Wondertan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Wondertan @liamsi @jbowen93 @renaynay