Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(share/p2p)!: share.ErrNamespaceNotFound and integration into shrex-nd #2230

Merged
merged 7 commits into from
May 19, 2023

Conversation

distractedm1nd
Copy link
Member

This PR replaces #2156 , as gh was not showing the diff properly. It closes #2145

@distractedm1nd distractedm1nd added area:shares Shares and samples kind:break! Attached to breaking PRs kind:fix Attached to bug-fixing PRs labels May 19, 2023
@distractedm1nd distractedm1nd self-assigned this May 19, 2023
share/p2p/shrexnd/server.go Show resolved Hide resolved
share/p2p/shrexnd/server.go Show resolved Hide resolved
@distractedm1nd distractedm1nd merged commit 62a0b97 into main May 19, 2023
16 of 18 checks passed
@distractedm1nd distractedm1nd deleted the errnamespacenotfound branch May 19, 2023 12:10
vgonkivs pushed a commit to vgonkivs/celestia-node that referenced this pull request May 22, 2023
…x-nd (celestiaorg#2230)

This PR replaces celestiaorg#2156 , as gh was not showing the diff properly. It
closes celestiaorg#2145

---------

Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:shares Shares and samples kind:break! Attached to breaking PRs kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(shares/GetSharesByNamespace): missing response type ErrNamespaceNotFound
3 participants