fix(share/shrex): return aggregated error if context Deadline reached

[walldiss]

Overview

Errors were lost on context deadline

[Wondertan]

Hmm, it's correct to return a context error when the caller canceled it, unless the context cancelation error comes from the internal or sub-context. Is this the latter case?

[walldiss]

Shrex will return context error, wrapped with other errors. It helps a lot to have aggregated errors dealing with shrex issues on other people nodes.

[Wondertan]

Ok, the Join kinda fixes my concern

[codecov-commenter]

Codecov Report

Merging #2243 (39371a7) into main (ec41fcb) will decrease coverage by 0.22%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #2243      +/-   ##
==========================================
- Coverage   50.63%   50.42%   -0.22%     
==========================================
  Files         150      150              
  Lines        9299     9297       -2     
==========================================
- Hits         4709     4688      -21     
- Misses       4195     4211      +16     
- Partials      395      398       +3     

Impacted Files	Coverage Δ
share/getters/shrex.go	65.58% <75.00%> (-0.45%)	⬇️

... and 6 files with indirect coverage changes