Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: bump arabica testnet params #2281

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

Bidon15
Copy link
Member

@Bidon15 Bidon15 commented May 30, 2023

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@github-actions github-actions bot added the external Issues created by non node team members label May 30, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2281 (32e62f1) into main (5d0424a) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2281      +/-   ##
==========================================
- Coverage   50.65%   50.58%   -0.08%     
==========================================
  Files         154      154              
  Lines        9620     9620              
==========================================
- Hits         4873     4866       -7     
- Misses       4323     4328       +5     
- Partials      424      426       +2     
Impacted Files Coverage Δ
nodebuilder/p2p/bootstrap.go 6.66% <ø> (ø)
nodebuilder/p2p/genesis.go 0.00% <ø> (ø)
nodebuilder/p2p/network.go 57.89% <ø> (ø)

... and 4 files with indirect coverage changes

@jcstein
Copy link
Member

jcstein commented May 30, 2023

suggestion: upgrade docgen example data (unless it's...automatically generated 😄) jcstein@58b4343

@jcstein
Copy link
Member

jcstein commented May 30, 2023

Testing if #2282 still happens on this branch

@jcstein
Copy link
Member

jcstein commented May 30, 2023

Update, it does start successfully.

This PR resolves #2282

@renaynay renaynay changed the title chore: bump arabica testnet params chore!: bump arabica testnet params May 31, 2023
@renaynay renaynay added the kind:break! Attached to breaking PRs label May 31, 2023
@vgonkivs vgonkivs merged commit b62452a into celestiaorg:main May 31, 2023
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members kind:break! Attached to breaking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants