Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blob): add marshaling for blob and proof #2286

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

vgonkivs
Copy link
Member

Overview

Add marshaler fro blob and proof

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

blob/blob.go Show resolved Hide resolved
distractedm1nd
distractedm1nd previously approved these changes May 31, 2023
blob/blob.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Merging #2286 (a94b1df) into main (d53efbd) will increase coverage by 0.30%.
The diff coverage is 86.04%.

@@            Coverage Diff             @@
##             main    #2286      +/-   ##
==========================================
+ Coverage   50.60%   50.90%   +0.30%     
==========================================
  Files         154      154              
  Lines        9620     9663      +43     
==========================================
+ Hits         4868     4919      +51     
+ Misses       4328     4320       -8     
  Partials      424      424              
Impacted Files Coverage Δ
blob/blob.go 65.88% <86.04%> (+20.64%) ⬆️

... and 2 files with indirect coverage changes

Wondertan
Wondertan previously approved these changes Jun 1, 2023
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

renaynay
renaynay previously approved these changes Jun 1, 2023
blob/blob.go Outdated Show resolved Hide resolved
@vgonkivs vgonkivs dismissed stale reviews from renaynay and Wondertan via 3f41fc2 June 1, 2023 09:27
@vgonkivs vgonkivs merged commit 135622a into celestiaorg:main Jun 1, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:blob kind:feat Attached to feature PRs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants