Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nodebuilder): decrease lifecycle timeout for LN #2290

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

Wondertan
Copy link
Member

@Wondertan Wondertan commented May 31, 2023

LNs don't need that much time to run

@Wondertan Wondertan self-assigned this May 31, 2023
@Wondertan Wondertan marked this pull request as ready for review May 31, 2023 17:26
nodebuilder/node_test.go Show resolved Hide resolved
@renaynay renaynay added the kind:fix Attached to bug-fixing PRs label Jun 1, 2023
@renaynay renaynay enabled auto-merge (squash) June 1, 2023 12:15
@Wondertan Wondertan disabled auto-merge June 1, 2023 12:17
@codecov-commenter
Copy link

Codecov Report

Merging #2290 (1a7dca2) into main (1c1327b) will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##             main    #2290   +/-   ##
=======================================
  Coverage   50.80%   50.81%           
=======================================
  Files         154      154           
  Lines        9663     9671    +8     
=======================================
+ Hits         4909     4914    +5     
- Misses       4328     4330    +2     
- Partials      426      427    +1     
Impacted Files Coverage Δ
nodebuilder/node.go 61.84% <83.33%> (+4.48%) ⬆️

... and 4 files with indirect coverage changes

@renaynay renaynay merged commit 218ab99 into main Jun 1, 2023
16 of 18 checks passed
@renaynay renaynay deleted the hlib/node/decrease-timeout branch June 1, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants