fix(gateway): remove the GetByHeight hussle and rely on Module's logic #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
requested review from
vgonkivs,
distractedm1nd and
walldiss
as code owners
Wondertan
changed the title
|
|
Codecov Report
@@ Coverage Diff @@
## main #2302 +/- ##
==========================================
+ Coverage 50.82% 51.02% +0.20%
==========================================
Files 154 154
Lines 9671 9633 -38
==========================================
Hits 4915 4915
+ Misses 4329 4292 -37
+ Partials 427 426 -1
|
vgonkivs
previously approved these changes
Jun 2, 2023
Wondertan
force-pushed
the
hlib/gateway-get-header-attempt-2
branch
from
ae4311f
to
24c5fa6
Compare
renaynay
approved these changes
Jun 2, 2023
vgonkivs
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.