Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump otel, go-header, and go-fraud #2472

Merged
merged 5 commits into from
Jul 13, 2023
Merged

chore(deps): bump otel, go-header, and go-fraud #2472

merged 5 commits into from
Jul 13, 2023
+296 −298

Conversation

walldiss
Copy link
Member

Updates otel to latest version

Depends on celestiaorg/go-header#84 , celestiaorg/go-fraud#17

@walldiss walldiss added kind:deps Pull requests that update a dependency file area:metrics Related to measuring/collecting node metrics labels Jul 13, 2023
@walldiss walldiss self-assigned this Jul 13, 2023
@walldiss walldiss force-pushed the update_otel branch 3 times, most recently from d1746f2 to 9fad72c Compare July 13, 2023 13:01
@Wondertan
Copy link
Member

The API seems to change for good.

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023 •
edited
Loading

Codecov Report

Merging #2472 (bd6395b) into main (eea0668) will decrease coverage by 0.09%.
The diff coverage is 3.16%.

@@            Coverage Diff             @@
##             main    #2472      +/-   ##
==========================================
- Coverage   52.89%   52.80%   -0.09%     
==========================================
  Files         156      156              
  Lines        9964     9972       +8     
==========================================
- Hits         5270     5266       -4     
- Misses       4231     4240       +9     
- Partials      463      466       +3
Impacted Files Coverage Δ
das/metrics.go 9.75% <0.00%> (-0.17%) ⬇️
share/getters/shrex.go 66.66% <0.00%> (-0.77%) ⬇️
share/p2p/discovery/metrics.go 11.53% <0.00%> (ø)
share/p2p/peers/metrics.go 9.93% <0.00%> (-0.32%) ⬇️
state/metrics.go 0.00% <0.00%> (ø)
nodebuilder/settings.go 64.70% <100.00%> (+0.42%) ⬆️

... and 5 files with indirect coverage changes

@Wondertan
Copy link
Member

@walldiss, so is this RFR?

@walldiss walldiss marked this pull request as ready for review July 13, 2023 14:07
renaynay
renaynay previously approved these changes Jul 13, 2023
View reviewed changes
nodebuilder/settings.go Outdated Show resolved Hide resolved
@renaynay renaynay changed the title chore(deps): bump otel chore(deps): bump otel, go-header, and go-fraud Jul 13, 2023
@walldiss walldiss requested a review from renaynay July 13, 2023 14:44
@Wondertan Wondertan enabled auto-merge (squash) July 13, 2023 14:55
@Wondertan Wondertan merged commit 11dced4 into celestiaorg:main Jul 13, 2023
12 of 14 checks passed
This was referenced Jul 14, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@renaynay renaynay renaynay approved these changes

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd distractedm1nd is a code owner

Assignees

@walldiss walldiss

Labels
area:metrics Related to measuring/collecting node metrics kind:deps Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@walldiss @Wondertan @codecov-commenter @renaynay