feat(nodebuilder): Invoke traces from fx

[vgonkivs]

Overview

Invoke traces from the fx

Checklist

• New and updated code has appropriate documentation
• New and updated code has new and/or updated testing
• Required CI checks are passing
• Visual proof for any user facing features like CLI or documentation updates
• Linked issues closed with keywords

[codecov-commenter]

Codecov Report

Merging #2477 (9d7dfb1) into main (05e00e8) will decrease coverage by 0.16%.
The diff coverage is 9.09%.

@@            Coverage Diff             @@
##             main    #2477      +/-   ##
==========================================
- Coverage   52.76%   52.61%   -0.16%     
==========================================
  Files         156      156              
  Lines        9966     9993      +27     
==========================================
- Hits         5259     5258       -1     
- Misses       4241     4273      +32     
+ Partials      466      462       -4     

Impacted Files	Coverage Δ
nodebuilder/settings.go	45.94% <9.09%> (-18.34%)	⬇️

... and 7 files with indirect coverage changes

[vgonkivs]

One more optimisation that we can do is to pass []*resource.Resource to initMetrics/initTraces as this options are equal in both metrics and traces:

resource.NewWithAttributes(
			semconv.SchemaURL,
			semconv.ServiceNamespaceKey.String(fmt.Sprintf("Celestia-%s", nodeType)),
			semconv.ServiceNameKey.String(fmt.Sprintf("semver-%s", buildInfo.SemanticVersion)),
			semconv.ServiceInstanceIDKey.String(fmt.Sprintf("%s/%s", network.String(), peerID.String()))),
		)

[renaynay]

As I understand, it's still being tested by @jrmanes

[tty47]

As I understand, it's still being tested by @jrmanes

yes @renaynay , I'm in contact with Slava about this topic :)

[tty47]

hello team!

regarding the latest commit:

This is how it will look like:

We could find the network/peer.ID in the services:

and the node type in the metrics:

thank you so much @vgonkivs 😃