Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for namespace version 0 #2514

Merged
merged 2 commits into from
Jul 31, 2023
Merged

fix: check for namespace version 0 #2514

merged 2 commits into from
Jul 31, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jul 25, 2023

Closes #2513

@rootulp rootulp self-assigned this Jul 25, 2023
@github-actions github-actions bot added the external Issues created by non node team members label Jul 25, 2023
Wondertan
Wondertan approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@rootulp rootulp added the kind:fix Attached to bug-fixing PRs label Jul 30, 2023
@renaynay renaynay enabled auto-merge (squash) July 31, 2023 11:45
@renaynay renaynay merged commit 329ab20 into celestiaorg:main Jul 31, 2023
13 of 15 checks passed
@rootulp rootulp deleted the rp/fix-validate-for-blob branch July 31, 2023 13:02
@faddat faddat mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@renaynay renaynay renaynay approved these changes

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd distractedm1nd is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees

@rootulp rootulp

Labels
external Issues created by non node team members kind:fix Attached to bug-fixing PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValidateForData is missing a check for namespace version == 0
3 participants
@rootulp @Wondertan @renaynay