feat(cmd): use rpc client instead of http.Request

[vgonkivs]

Overview

Ideas behind such rework are pretty simple:

1. to simplify code.
   Me and @Wondertan love generic code but IMO the rpc is too complicated and hard to understand and maintain. Also, it contained a lot of hidden bugs that were found by @jcstein(bug: illegal base64 data at input byte during unmarshalling blob.Commitment #2500, blob.GetAll not returning correct base64 data, GetShare and GetSharesByNamespace also don't work #2503). I believe that extracting each module(or even a method) to its own command will simplify this package a lot.
2. move from the raw http.Request.
   We've already had a rpc client but continue using http.Request. Also, the generic approach did not give us control over the returned value.

TODO: extract errors

Checklist

• New and updated code has appropriate documentation
• New and updated code has new and/or updated testing
• Required CI checks are passing
• Visual proof for any user facing features like CLI or documentation updates
• Linked issues closed with keywords

[codecov-commenter]

Codecov Report

Merging #2521 (12b261d) into main (208bb86) will decrease coverage by 0.94%.
Report is 7 commits behind head on main.
The diff coverage is 8.88%.

@@            Coverage Diff             @@
##             main    #2521      +/-   ##
==========================================
- Coverage   52.64%   51.71%   -0.94%     
==========================================
  Files         156      157       +1     
  Lines        9990    10075      +85     
==========================================
- Hits         5259     5210      -49     
- Misses       4266     4409     +143     
+ Partials      465      456       -9     

Files Changed	Coverage Δ
cmd/celestia/rpc.go	18.63% <3.70%> (+3.99%)	⬆️
cmd/celestia/blob.go	9.80% <9.80%> (ø)

... and 9 files with indirect coverage changes

[jcstein]

ack - LGTM

[renaynay]

Looks like there's a lint issue, but otherwise I'm okay with it 🙏🏻 tested it myself (not the plaintext option yet, but that will be a really nice feature)

I'll make an issue for the commitment to also be returned for Submit.

[vgonkivs]

I'll make an issue for the commitment to also be returned for Submit.

I've already implemented it @renaynay

[vgonkivs]

FYI @jcstein, changes in Blob's commands:

• they are now lower case(submit, get)
• using - between words instead of camel case(get-all, get-proof)
• submitting the data now returns not only the height but also the commitment of the Blob.
• Added flag --plaintext that converts the Blob's data from base64 string(gm instead of Z20=). To enable this command you should add --plaintext=true in the end of the command

[vgonkivs]

[jcstein]

thanks for the context! a question on this before opening a PR to the docs:

are the rest of the methods still camelcase? this seems like it would get confusing as a user if we didn't change all methods.

i.e.

celestia rpc blob get-all [args...]
celestia rpc blob get [args...]
and then
celestia rpc state BalanceForAddress [args...]
celestia rpc p2p Info [args...]
celestia rpc header GetByHeight [ args...]
celestia rpc node Info
celestia rpc das SamplingStats

[jcstein]

suggestion: allow --plaintext to set --plaintext=TRUE by default

[jcstein]

i also think we need to set the API version to match the expected node release version cc @MSevey @adlerjohn

celestia rpc node Info

{
  "jsonrpc": "2.0",
  "result": {
    "type": 2,
    "api_version": "v0.2.1"
  },
  "id": 1
}

[vgonkivs]

are the rest of the methods still camelcase? this seems like it would get confusing as a user if we didn't change all methods.

Yeah, they will be fixed in subsequent PRs

[jcstein]

this plaintext flag is goated 👏