Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nodebuilder/p2p): BlockTime from 15 sec --> 10 sec #2692

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

renaynay
Copy link
Member

Block times will be closer to 10 seconds on average than 15, so we should shift this to make calculations based on block time in our codebase more accurate.

This will also fix issues with syncing arabica-10

vgonkivs
vgonkivs previously approved these changes Sep 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

Merging #2692 (ffbce02) into main (c650453) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2692      +/-   ##
==========================================
- Coverage   51.35%   51.34%   -0.01%     
==========================================
  Files         159      159              
  Lines       10698    10698              
==========================================
- Hits         5494     5493       -1     
- Misses       4725     4728       +3     
+ Partials      479      477       -2     
Files Changed Coverage Δ
nodebuilder/p2p/network.go 57.89% <ø> (ø)
das/options.go 32.25% <100.00%> (ø)

... and 6 files with indirect coverage changes

@renaynay renaynay merged commit a770ca1 into celestiaorg:main Sep 11, 2023
13 of 15 checks passed
@renaynay renaynay deleted the block-time branch September 11, 2023 13:14
renaynay added a commit to renaynay/celestia-node that referenced this pull request Sep 13, 2023
…#2692)

Block times will be closer to 10 seconds on average than 15, so we
should shift this to make calculations based on block time in our
codebase more accurate.

This will also fix issues with syncing `arabica-10`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants