Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(swamp/tests)skip tests #2802

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ test-unit-race:
## test-swamp: Running swamp tests located in nodebuilder/tests
test-swamp:
@echo "--> Running swamp tests"
@go test ./nodebuilder/tests
@go test ./nodebuilder/tests --skip "TestHeaderSubscription|TestBlobModule|TestShrexNDFromLights|TestShrexNDFromLightsWithBadFulls|TestBridgeNodeAsBootstrapper|TestFullDiscoveryViaBootstrapper|TestFullReconstructFromFulls|TestFullReconstructFromLights|TestSyncAgainstBridge_NonEmptyChain|TestSyncAgainstBridge_EmptyChain|TestSyncStartStopLightWithBridge|TestSyncLightAgainstFull|TestSyncLightWithTrustedPeers"
.PHONY: test-swamp

## test-swamp-race: Running swamp tests with data race detector located in node/tests
Expand Down
2 changes: 1 addition & 1 deletion nodebuilder/tests/blob_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ func TestBlobModule(t *testing.T) {
b, err := fullClient.Blob.Get(ctx, height, newBlob.Namespace(), newBlob.Commitment)
assert.Nil(t, b)
require.Error(t, err)
require.ErrorIs(t, err, blob.ErrBlobNotFound)
require.Equal(t, err.Error(), blob.ErrBlobNotFound.Error())
},
},
}
Expand Down
1 change: 1 addition & 0 deletions nodebuilder/tests/fraud_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ Another note: this test disables share exchange to speed up test results.
9. Try to start a Full Node(FN) that contains a BEFP in its store.
*/
func TestFraudProofHandling(t *testing.T) {
t.Skip()
ctx, cancel := context.WithTimeout(context.Background(), swamp.DefaultTestTimeout)
t.Cleanup(cancel)

Expand Down
2 changes: 2 additions & 0 deletions nodebuilder/tests/sync_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,8 @@ func TestSyncStartStopLightWithBridge(t *testing.T) {
light = sw.NewLightNode()
require.NoError(t, light.Start(ctx))

lightClient = getAdminClient(ctx, light, t)

// ensure when light node comes back up, it can sync the remainder of the chain it
// missed while sleeping
h, err = lightClient.Header.WaitForHeight(ctx, 40)
Expand Down
Loading