node: remove InitWith #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlerjohn
previously approved these changes
Dec 20, 2021
Wondertan
force-pushed
the
hlib/remove-init-with
branch
from
1acc630
to
8d382d2
Compare
Wondertan
dismissed stale reviews from renaynay and adlerjohn
The base branch was changed.
Wondertan
added a commit
that referenced
this pull request
Dec 21, 2021
Wondertan
added a commit
that referenced
this pull request
Dec 21, 2021
Wondertan
force-pushed
the
hlib/remove-init-with
branch
from
943482a
to
a518c28
Compare
Wondertan
force-pushed
the
hlib/remove-init-with
branch
from
a518c28
to
3a6b4f6
Compare
Bidon15
approved these changes
Dec 23, 2021
renaynay
approved these changes
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This PR removes redundant
node.InitWithas we have a separate option to pass a Config, so to have similar functionality, one should usenode.Init(node.WithConfig()).